Hi David, thanks for working on including the tinker-s. Some comments below. Am Sonntag, 2. September 2018, 12:04:48 CEST schrieb beagleboard@xxxxxxxxxxxxxxxxxxx: > Hi, > > The ASUS Tinker Board S : > https://www.asus.com/uk/Single-Board-Computer/Tinker-Board-S/ > > Is a variant on the original ASUS Tinker Board, the main difference > being that the "S" has eMMC. > > This patchset sets up the device tree for the "S". It is based on the > patches used with the debian distribution which ships with the device : > https://github.com/TinkerBoard/debian_kernel/blob/develop/arch/arm/boot/dts/rk3288-miniarm.dts > > So this is really just mainlining the support. > > I've split the changed into three parts: These general comments apply to all 3 of your patches: (1) Please follow the general guildelines for sending patches, like described in Documentation/process/5.Posting.rst in your kernel tree like: - send output of "git format-patch" - signed-off-by line - full name as "from" - ideally use "git send-email" - no html mails - no mangled content (your mail client replaced all tabs with spaces) (2) Please keep things to lower cases. So name your board for example rk3288-tinker-s.dts (3) When adding a board, please also add a corresponding entry to Documentation/devicetree/bindings/arm/rockchip.txt (4) When adding a board variant - please don't simply copy devicetrees. Instead ideally create a shared dtsi, that both the tinker.dts and tinker-s can include. For reference you can look at the Rock960 CE+EE patchset posted today: https://patchwork.kernel.org/cover/10594427/ (5) Please add lists and maintainers. I'm missing - linux-arm-kernel@xxxxxxxxxxxxxxxxxxx - Devicetree binding maintainers: - robh+dt@xxxxxxxxxx - mark.rutland@xxxxxxx Thanks Heiko
