Hi Anson, On Wed, Sep 05, 2018 at 05:26:46PM +0800, Anson Huang wrote: > This patch adds wakeup function support for egalax touch > screen, if "wakeup-source" is added to device tree's egalax > touch screen node, the wakeup function will be enabled, and > egalax touch screen will be able to wakeup system from suspend. > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> I think you messed up the order of the patches, this patch whould come after the PATCH 2/2. You first create the property and then use it. If someone checks out right here, he would find an inconsistency between the dts property and this code. You can either send a version 2 with the correct order or check if Dmitry and Rob are willing to sync for who takes first the patch first. Andi