On Wednesday, March 05, 2014 5:33 PM, Liviu Dudau wrote: > On Wed, Mar 05, 2014 at 10:20:28AM +0900, Jingoo Han wrote: > > On Wednesday, March 05, 2014 12:50 AM, Liviu Dudau wrote: > > > > > > Several platforms use a rather generic version of parsing > > > the device tree to find the host bridge ranges. Move the common code > > > into the generic PCI code and use it to create a pci_host_bridge > > > structure that can be used by arch code. > > > > > > Based on early attempts by Andrew Murray to unify the code. > > > Used powerpc and microblaze PCI code as starting point. > > > > > > Signed-off-by: Liviu Dudau <Liviu.Dudau@xxxxxxx> > > > > > > diff --git a/drivers/pci/host-bridge.c b/drivers/pci/host-bridge.c > > > index 8708b652..800678a 100644 > > > --- a/drivers/pci/host-bridge.c > > > +++ b/drivers/pci/host-bridge.c [.....] > > > + > > > + /* Apply architecture specific fixups for the ranges */ > > > + pcibios_fixup_bridge_ranges(resources); > > > > It also makes compile problem with exynos_defconfig as below: > > > > drivers/built-in.o: In function `pci_host_bridge_of_get_ranges': > > drivers/pci/host-bridge.c:157: undefined reference to `pcibios_fixup_bridge_ranges' > > Does that mean that exynos_defconfig doesn't define CONFIG_OF? How do you > compile all the .dts files then? Should CONFIG_OF not be added to the default config > file? Now, I am testing your patches with ARM32 platform such as Exynos SoCs. And the default 'exynos_defconfig' already defines CONFIG_OF=y. (./arch/arm/configs/exynos_defconfig) > > Other than that, your comment is correct. drivers/pci/host-bridge.c gets compiled > in regardless of CONFIG_OF and I need to provide an empty implementation for > pcibios_fixup_bridge_ranges(). There is no pcibios_fixup_bridge_ranges() in ./arch/arm/ directory. So, it makes the compile problem. I think that the empty implementation for pcibios_fixup_bridge_ranges() may be necessary, in order to the compile problem. Or, __weak pcibios_fixup_bridge_ranges() would be used. Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
