Hi Sergei, On Friday, August 24, 2018 1, linux-renesas-soc-owner@xxxxxxxxxxxxxxx wrote: > On 08/22/2018 11:57 PM, Chris Brandt wrote: > > +static const u16 sh_eth_offset_fast_rza2[SH_ETH_MAX_REGISTER_OFFSET] = > { > > + SH_ETH_OFFSET_DEFAULTS, > > + (snip) > > + [RFCR] = 0x01f4, > > + [MAFCR] = 0x01f8, > > +}; > > + > > This array is absolutely the same as sh_eth_offset_fast_sh4[], except > the latter > is (more or less) sorted. You're right. I'll just use sh_eth_offset_fast_sh4[]. > > + > > + switch (mdp->speed) { > > + case 10: /* 10BASE */ > > + sh_eth_modify(ndev, ECMR, RTM, 0); > > + break; > > + case 100:/* 100BASE */ > > + sh_eth_modify(ndev, ECMR, RTM, RTM); > > + break; > > + } > > +} > > + > > Seems the same as sh_eth_set_rate_rcar(), except for the bit name... You're right. I looked at the other sh_eth_set_rate_xxx() but didn't seem to find one that matched. But, sh_eth_set_rate_rcar() does match. I'll use that one. Thanks, Chris