On Fri, Aug 24, 2018 at 08:31:42AM +0000, Fabrizio Castro wrote: > Hello Simon, > > Thank you for the feedback! > > > > > > > In theory CAN could be broken if renesas,can-clock-select is set to 0x1 > > > (clkp2) in the DT, as this value will be written to the CAN Clock Select > > > Register. However if the documentation is followed there will be no > > > problems. > > > > > > We should probably update the driver to fix this though, which will be a > > > change specific to all RZ/G2 devices, so perhaps we should also be adding > > > a "renesas,rzg-gen2-can" family compatible string as well? (to driver and > > > documentation) > > > > Yes, I think that sounds reasonable. > > > > But in that case we should pre-emptively not use renesas,rcar-gen3-can for > > RZ/G2. > > What do you think about the following: > https://patchwork.kernel.org/patch/10573795/ > https://patchwork.kernel.org/patch/10573791/ > https://patchwork.kernel.org/patch/10573805/ I think that is the right approach.
