On 05.03.2014 00:51, Sören Brinkmann wrote: > Hi Kedar, > > On Tue, 2014-03-04 at 06:50PM +0530, Kedareswara rao Appana wrote: >> This patch adds xilinx CAN controller support. >> This driver supports both ZYNQ CANPS and Soft IP >> AXI CAN controller. >> > [...] >> diff --git a/Documentation/devicetree/bindings/net/can/xilinx_can.txt b/Documentation/devicetree/bindings/net/can/xilinx_can.txt >> new file mode 100644 >> index 0000000..0e57103 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/can/xilinx_can.txt >> @@ -0,0 +1,45 @@ >> +Xilinx Axi CAN/Zynq CANPS controller Device Tree Bindings >> +--------------------------------------------------------- >> + >> +Required properties: >> +- compatible : Should be "xlnx,zynq-can-1.00.a" for Zynq CAN >> + controllers and "xlnx,axi-can-1.00.a" for Axi CAN >> + controllers. >> +- reg : Physical base address and size of the Axi CAN/Zynq >> + CANPS registers map. >> +- interrupts : Property with a value describing the interrupt >> + number. >> +- interrupt-parent : Must be core interrupt controller >> +- clock-names : List of input clock names - "ref_clk", "aper_clk" > > Let's reconsider these names. These are rather Zynq specific names. Does > the IP documentation use these as well? The names should match the > naming used for the IP, rather than the SOC. Is this the correct data sheet: > http://www.xilinx.com/support/documentation/ip_documentation/axi_can/v1_03_a/ds791_axi_can.pdf > ? According to that the names should rather be 's_axi_aclk' and > 'can_clk', IMHO. > > Sören > And when renaming stuff anyway: + +#define DRIVER_NAME "XILINX_CAN" + should be changed to + +#define DRIVER_NAME "xilinx_can" + Regards, Oliver -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
