Hi David,
Le jeu. 23 août 2018 à 12:41, David Laight <David.Laight@xxxxxxxxxx>
a écrit :
From: Paul Cercueil
Sent: 22 August 2018 18:30
The maximum value found in that array is 15, there's no need to
store
these values as uint32_t, a uint8_t is enough.
Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
---
drivers/memory/jz4780-nemc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/memory/jz4780-nemc.c
b/drivers/memory/jz4780-nemc.c
index bcf06adefc96..ef3f20e46590 100644
--- a/drivers/memory/jz4780-nemc.c
+++ b/drivers/memory/jz4780-nemc.c
@@ -161,7 +161,7 @@ static bool jz4780_nemc_configure_bank(struct
jz4780_nemc *nemc,
* Conversion of tBP and tAW cycle counts to values supported by
the
* hardware (round up to the next supported value).
*/
- static const uint32_t convert_tBP_tAW[] = {
+ static const u8 convert_tBP_tAW[] = {
0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10,
/* 11 - 12 -> 12 cycles */
@@ -232,7 +232,7 @@ static bool jz4780_nemc_configure_bank(struct
jz4780_nemc *nemc,
return false;
}
- smcr |= convert_tBP_tAW[cycles] << NEMC_SMCR_TBP_SHIFT;
+ smcr |= (u32)convert_tBP_tAW[cycles] << NEMC_SMCR_TBP_SHIFT;
You don't need the cast here.
OK, I will remove them in V2.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes,
MK1 1PT, UK
Registration No: 1397386 (Wales)
