Hi, On Mon, Jul 23, 2018 at 4:33 PM, Rob Herring <robh@xxxxxxxxxx> wrote: >> OK, I guess I will try again then and you can tell me when I get it >> right (unless you tell me I should just change the driver to not use >> named registers at all). How about: >> >> - reg: >> - For "qcom,sdm845-qmp-usb3-phy": >> - index 0: address and length of register set for PHY's common serdes >> block. >> - index 1: address and length of the DP_COM control block. > > Instead of repeating index 0 below, just say "for > 'qcom,sdm845-qmp-usb3-phy' only" here. > >> - For all others: >> - index 0: address and length of register set for PHY's common serdes >> block. >> - reg-names: >> - For "qcom,sdm845-qmp-usb3-phy": >> - Should be: "reg-base", "dp_com" >> - For all others: >> - The reg-names property shouldn't be defined. To close the loop, I've just posted <https://lore.kernel.org/patchwork/patch/972177/> AKA ("dt-bindings: phy: qcom-qmp: Cleanup the 'reg' documentation as per review"). Hopefully that addresses everything properly but if not I'm happy to spin it again. Thanks for your patience in helping me understand what you were looking for. -Doug -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
