On Mon, 23 Jul 2018 11:34:43 +0200 Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Sun, Jul 22, 2018 at 8:29 AM, Boris Brezillon > <boris.brezillon@xxxxxxxxxxx> wrote: > > +Arnd, Rob and the DT ML. > > > > On Sat, 21 Jul 2018 14:53:47 -0700 > > Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > > > >> On 07/21/2018 01:00 PM, Anders Roxell wrote: > >> > JZ4780_NEMC doesn't depend on OF, and if OF isn't enabled we get this > >> > error: > >> > drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’: > >> > drivers/memory/jz4780-nemc.c:72:10: error: implicit declaration of > >> > function ‘of_read_number’; did you mean ‘down_read_nested’? > >> > [-Werror=implicit-function-declaration] > >> > bank = of_read_number(prop, 1); > >> > ^~~~~~~~~~~~~~ > >> > down_read_nested > > > > Looks like of.h defines stubs so that people can compile-test without > > CONFIG_OF selected. Maybe we should move of_read_number() and > > of_read_ulong() out of the #ifdef CONFIG_OF section. > > That seems fine, though the added dependency seems appropriate > here as well. of_read_number() is rarely used, and for the most part in > powerpc specific code that is guaranteed to have CONFIG_OF enabled, > so it's not that likely to cause many more problems. Ok, then I'll let Miquel apply Anders' patch to the NAND tree. Thanks for your feedback. Boris -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
