Hi Jonathan, On Sun, Jul 22, 2018 at 09:11:11AM +0100, Jonathan Cameron wrote: > On Sat, 21 Jul 2018 21:59:22 +0200 > Marcus Folkesson <marcus.folkesson@xxxxxxxxx> wrote: > [snip] > > +Optional properties: > > + - device-addr: Device address when multiple MCP3911 chips are present on the > > + same SPI bus. Valid values are 0-3. Defaults to 0. > > + - external-clock: Use external clock instead of crystal oscillator. > As mentioned, in the code, can we use the standard fixed clock bindings here. > We don't actually care what the value is, but it might be nice to be able to > power down the clock if we are suspending or something.. > > > + - external-vref: Use external voltage reference > > + - vref-supply: Phandle to the external reference voltage supply. (only valid in combination with `external-vref`) > > Just use the optional regulator stuff and get rid of the bool. > > > + - ch0-width: width for channel0. Valid widths are 16 and 24bits. > > + - ch1-width: width for channel1. Valid widths are 16 and 24bits. > > As I asked in the code, are these a function of the wiring etc or are > they something we should really be leaving up to userspace (with a sensible > default). > I agree with all of your comments. I will remove the channel width properties and fix the regulator/clock bindings. Thanks, Best regards Marcus Folkesson
Attachment:
signature.asc
Description: PGP signature
