Adding Linus ... On 17/07/18 16:30, Aapo Vienamo wrote: ... >>>>> +Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt. >>>>> + >>>>> +The values accepted by power-source property are >>>>> +TEGRA_IO_PAD_VOLTAGE_1V8 and TEGRA_IO_PAD_VOLTAGE_3V3, which are defined >>>>> +in dt-bindings/pinctrl/pinctrl-tegra-io-pad.h. >>>> >>>> You need to list out what properties the child nodes can have. >>>> >>>> power-source needs a vendor prefix. >>> >>> Isn't it a generic pinctrl property? >> >> I don't know offhand. Doesn't look like it if you have custom values. > > It's listed under "Supported generic properties" in > pinctrl-bindings.txt. The convention seems to be not to add a vendor > prefix even though such custom macro values are used. The property is > currently used by qcom,pmic-gpio, qcom,pmic-mpp, and renesas,pfc-pinctrl. > I could not find a bindings document describing it with a vendor prefix. Looking at other users of the 'power-source' property it is not clear to me if the values should/can be vendor specific or not. I see cases where some people use definitions and others use actual voltages. Linus, any recommendations here? Cheers Jon -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
