On 2018-07-19 13:05, Caprioru, Mircea wrote: > On Thu, 2018-07-19 at 11:09 +0200, Peter Rosin wrote: >> On 2018-07-19 09:26, Caprioru, Mircea wrote: >>> On Wed, 2018-07-18 at 15:09 +0200, Peter Rosin wrote: >>>> On 2018-07-17 15:44, Mircea Caprioru wrote: >>>>> Adding dt-bindings documentation for adgs1408/1409 multiplexer. >>>>> The >>>>> bindings follow the standard SPI and mux bindings and do not >>>>> require any >>>>> additional custom properties. >>>> >>>> However, both chips have general purpose output pins. I think it >>>> is >>>> customary to document the bindings for such things while at it? >>> >>> This functionality is not yet implemented in the driver. It does >>> not >>> make sense to document it just yet. Will add it when the driver >>> implements it. >> >> I disagree, and I also think 2/2 should come before 1/2, just to show >> that things are done in the proper order. That makes it clear that >> the >> driver does not implement random (or not yet existing) device-tree >> bindings. >> >> The bindings should not document the driver, they should document >> the hardware/interfaces. > > I was thinking of adding a custom property adi,gpos = <0 0 0 0>; to > configure the general purpose outputs but i am open to any sugestions. > What do you think of this approach ? No need for custom properties... Look at how e.g. adi,adg792a.txt handles the GPOs that are present on adg792g. Cheers, Peter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
