On 28/02/14 18:06, Russell King - ARM Linux wrote: >> +hdmi0: connector@1 { >> + compatible = "hdmi-connector"; >> + label = "hdmi"; >> + >> + hdmi_connector_in: endpoint { >> + remote-endpoint = <&tpd12s015_out>; >> + }; >> +}; > > It seems rather weird to have DVI connectors having an optional I2C > property, but HDMI (which augments DVI) not having that as at least an > optional property. I have added only the properties that I have used. I did think about the i2c for HDMI also, but thought that I don't use it, and so can't test it, and so I could well create a bad binding. And, as I don't see any issue in adding it later, when someone uses it, I decided to leave it out. > I can quite well see the iMX HDMI support needing an i2c bus here. > > Also, HDMI has two connector standards - type A and type B, much like > the single vs dual link of DVI. Again, DRM exposes this to userspace. True, but isn't that just a form factor? No functional differences? But I agree, we can add the two types here also to the compatible string. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature