On Fri, Feb 28, 2014 at 02:20:16PM +0200, Tomi Valkeinen wrote: > Add DT binding documentation for tpd12s015 encoder > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > Reviewed-by: Archit Taneja <archit@xxxxxx> > --- > .../devicetree/bindings/video/ti,tpd12s015.txt | 44 ++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/video/ti,tpd12s015.txt > > diff --git a/Documentation/devicetree/bindings/video/ti,tpd12s015.txt b/Documentation/devicetree/bindings/video/ti,tpd12s015.txt > new file mode 100644 > index 000000000000..26e6d32e3f20 > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/ti,tpd12s015.txt > @@ -0,0 +1,44 @@ > +TPD12S015 HDMI level shifter and ESD protection chip > +==================================================== > + > +Required properties: > +- compatible: "ti,tpd12s015" > + > +Optional properties: > +- gpios: CT CP HPD, LS OE and HPD gpios If this is supposed to give people a clue about what these GPIOs are, it completely fails to do this. CT CP? HPD is obviously the hotplug detect signal, but why are there two - HDMI only has a single detect pin on the connector. While it makes sense to stick all three into one property, is it possible that not all of these may be routed to a GPIO? If so, how do you specify that one (or more) of these does not exist? Another issue here is that other HDMI encoders are available - should every encoder define its own set of bindings, or should there be a base set of bindings which all encoders should conform to - such as always having a HDMI output port? -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
