Re: [PATCH v7 1/2] media: ov2680: dt: Add bindings for OV2680

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 4, 2018 at 9:52 AM Rui Miguel Silva <rui.silva@xxxxxxxxxx> wrote:
>
> Hi Jacopo,
> Hope your fine.
> Thanks for the review.
>
> On Wed 04 Jul 2018 at 09:58, jacopo mondi wrote:
> > Hi Rui,
> >    sorry, I'm a bit late, you're already at v7 and I don't want
> >    to
> > slow down inclusion with a few minor comments.
> >
> > Please bear with me and see below...
> >
> > On Tue, Jul 03, 2018 at 03:08:02PM +0100, Rui Miguel Silva
> > wrote:
> >> Add device tree binding documentation for the OV2680 camera
> >> sensor.
> >>
> >> CC: devicetree@xxxxxxxxxxxxxxx
> >> Signed-off-by: Rui Miguel Silva <rui.silva@xxxxxxxxxx>
> >> ---
> >>  .../devicetree/bindings/media/i2c/ov2680.txt  | 46
> >>  +++++++++++++++++++
> >>  1 file changed, 46 insertions(+)
> >>  create mode 100644
> >>  Documentation/devicetree/bindings/media/i2c/ov2680.txt
> >>
> >> diff --git
> >> a/Documentation/devicetree/bindings/media/i2c/ov2680.txt
> >> b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
> >> new file mode 100644
> >> index 000000000000..11e925ed9dad
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
> >> @@ -0,0 +1,46 @@
> >> +* Omnivision OV2680 MIPI CSI-2 sensor
> >> +
> >> +Required Properties:
> >> +- compatible: should be "ovti,ov2680".
> >> +- clocks: reference to the xvclk input clock.
> >> +- clock-names: should be "xvclk".
> >
> > Having a single clock source I think you can omit 'clock-names'
> > (or at
> > least not marking it as required)
>
> yeah, I see you point, but really all other OV sensors share this
> and
> the bellow clock/data-lanes properties as required, I will let Rob
> or
> Sakari take a call in this one.

I generally tell folks that *-names is not needed when there's only 1,
but having alignment across bindings is good too.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux