On Mon, Jul 2, 2018 at 10:45 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > On Fri, Jun 29, 2018 at 5:34 AM Anson Huang <Anson.Huang@xxxxxxx> wrote: > >> Some i.MX SoCs have GPIO clock gate in CCM, accessing >> GPIO registers needs to enable GPIO clock gate first, >> i.MX GPIO driver will enable clock gate if there is >> clock property in GPIO node of dtb, add optional property >> to i.MX GPIO binding doc. >> >> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > > Make sense since the gpio-mxc driver already supports this :) > >> +Optional properties: >> +- clocks: the clocks used by gpio bank > > Should the text be "the clock for clocking the GPIO silicon" > I guess that is what it is. And singularis? > > Does it hurt to give the clock a name? Like the common > "pclk" for peripheral clock or something similar that other > i.MX silicon uses? > > Fabio: can we have your ACK on this too. In case a respin will be made for this one I would suggest to add the name of the SoCs that need to pass the GPIO clock like imx6ul, imx6sll in the commit log. Reviewed-by: Fabio Estevam <fabio.estevam@xxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
