Neil Armstrong <narmstrong@xxxxxxxxxxxx> writes:
> On 24/06/2018 20:28, Martin Blumenstingl wrote:
>> S905W is a new SoC from the GXL series. It is a cost-reduced version of
>> the S905X.
>> The P281 development board from Amlogic uses the same layout as the P231
>> (S905D development board). Thus the new P281 board inherits
>> meson-gx-p23x-q20x.dtsi to avoid code-duplication.
>>
>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
>> ---
>> arch/arm64/boot/dts/amlogic/Makefile | 1 +
>> .../boot/dts/amlogic/meson-gxl-s905w-p281.dts | 22 +++++++++++++++++++
>> .../boot/dts/amlogic/meson-gxl-s905w.dtsi | 20 +++++++++++++++++
>> 3 files changed, 43 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s905w-p281.dts
>> create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s905w.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
>> index 34dd0e9b5cbb..6de2e7f5a9cc 100644
>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>> @@ -17,6 +17,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p230.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p231.dtb
>> +dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-p281.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-khadas-vim2.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb
>
> [...]
>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w.dtsi
>> new file mode 100644
>> index 000000000000..a4ed586d328b
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w.dtsi
>> @@ -0,0 +1,20 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2018 Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>.
>> + * Based on meson-gxl-s905x.dtsi:
>> + * - Copyright (c) 2016 Endless Computers, Inc.
>> + * Author: Carlo Caione <carlo@xxxxxxxxxxxx>
>> + */
>> +
>> +#include "meson-gxl.dtsi"
>> +#include "meson-gxl-mali.dtsi"
>> +
>> +/ {
>> + compatible = "amlogic,s905w", "amlogic,meson-gxl";
>> +};
>> +
>> +/* S905W only has access to it's internal PHY */
>> +ðmac {
>> + phy-mode = "rmii";
>> + phy-handle = <&internal_phy>;
>> +};
>>
>
> Hi Martin, Kevin, Carlo, Jerome,
>
> I would like to discuss how we should handle all the GXl variants,
> since from linux PoV, S905x, S905W and S805X are the same (S905W and
> S805X only has ledd IO balls, less IO available but same pinctrl
> interface).
>
> At some point, meson-gxl-s905w.dtsi and meson-gxl-s805x.dtsi will be exactly the same as meson-gxl-s905x.dtsi, and maybe the same for S905Z in the Fire TV.
>
> The can be multiple solution :
> - duplicate the files
> - unify all the internal-PHY-only GXL variant into a meson-gxl-sx05x.dtsi
> - use meson-gxl-s905x.dtsi and override the compatible in board dts
> - move the meson-gxl-s905x.dtsi into a separate meson-gxl-internal-phy.dtsi and include it instead of meson-gxl-s905x.dtsi and drop the intermediate package specific dtsi
I vote for unifying, but I think renaming is messy unncessary.
I'd rather just see reuse of the existing s905x .dtsi for any s905w or
s805x boards. We can add compatibles to s905x.dtsi if we really need
to, but for now I don't even thing that's necessary.
IOW, for this patch, drop the new s905w dtsi, and just have the board
.dts include the s905x.dtsi.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
