Hi Bjorn, On 6/7/2018 11:18 AM, Bjorn Andersson wrote: > On Wed 06 Jun 22:29 PDT 2018, Sricharan R wrote: > >> Hi Bjorn, >> >> On 6/7/2018 9:54 AM, Bjorn Andersson wrote: >>> On Wed 06 Jun 21:11 PDT 2018, Vinod wrote: >>> >>>> On 06-06-18, 09:17, Bjorn Andersson wrote: >>>>> On Tue 05 Jun 05:56 PDT 2018, Sricharan R wrote: >>>>> >>>>>> Hi Vinod, >>>>>> >>>>>> On 6/5/2018 11:49 AM, Vinod wrote: >>>>>>> On 05-06-18, 11:12, Sricharan R wrote: > [..] >>> If we ignore SMD for a while we have the following combinations: >>> >>> glink/wcss >>> y y - valid >>> y m - valid >>> y n - valid >>> m y - link failure (invalid) >>> m m - valid >>> m n - valid >>> n y - valid (platform uses wcss, but not glink) >>> n m - valid (-----"-----) >>> n n - valid >>> >>> So to distill this we have the two valid cases: >>> module/no if RPMSG_QCOM_GLINK_SMEM=m >>> yes/module/no if RPMSG_QCOM_GLINK_SMEM=y >>> >>> and the way you express that in Kconfig is the somewhat awkward >>> >>> depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n >>> >> >> ok, Having "depends on RPMSG_QCOM_GLINK_SMEM" takes care of the >> first 6 cases in the above list. >> >> But just was thinking that by allowing the last three combinations, >> there is a chance that some config that really needs GLINK_SMEM and WCSS, >> but selects only Q6V5_WCSS and misses to select GLINK_SMEM, >> would still built and make it non-functional, right ? >> > > It would allow you to compile a kernel with GLINk disabled that in > runtime loads a firmware that depends on GLINK being there. > > As it would be convenient to thereby state that "WCSS always depends on > GLINK" we can make the analog to 410 where "MSS always depends on SMD", > which isn't true when the same driver is reused on e.g. 845 - which > uses GLINK. > > > So my recommendation is that we stick with Kconfig options that > describes the build time dependencies of this particular driver, rather > than its runtime dependencies in a particular platform. > ok thanks. It sort of gave an impression that the last three combinations in the above list was only for "compile testing". Hence was thinking to have (COMPILE_TEST && RPMSG_QCOM_GLINK_SMEM=n). Anyways for WCSS, would drop the dependency on SMD and just have RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n. Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
