Hi, Stephen Anson Huang Best Regards! > -----Original Message----- > From: Stephen Boyd [mailto:sboyd@xxxxxxxxxx] > Sent: Saturday, June 2, 2018 2:19 PM > To: Anson Huang <anson.huang@xxxxxxx>; Stefan Wahren > <stefan.wahren@xxxxxxxx>; Fabio Estevam <fabio.estevam@xxxxxxx>; > kernel@xxxxxxxxxxxxxx; mark.rutland@xxxxxxx; matteo.lisi@xxxxxxxxxxx; > michael@xxxxxxxxxxxxxxxxxxxx; mturquette@xxxxxxxxxxxx; > robh+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx > Cc: linux-clk@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/2] clk: imx6ul: add GPIO clock gates > > Quoting Stefan Wahren (2018-05-22 05:25:35) > > > +++ b/include/dt-bindings/clock/imx6ul-clock.h > > > @@ -242,20 +242,25 @@ > > > #define IMX6UL_CLK_CKO2_PODF 229 > > > #define IMX6UL_CLK_CKO2 230 > > > #define IMX6UL_CLK_CKO 231 > > > +#define IMX6UL_CLK_GPIO1 232 > > > +#define IMX6UL_CLK_GPIO2 233 > > > +#define IMX6UL_CLK_GPIO3 234 > > > +#define IMX6UL_CLK_GPIO4 235 > > > +#define IMX6UL_CLK_GPIO5 236 > > > > this change looks like a breakage of devicetree ABI. You are changing the > mean of the existing clock IDs on i.MX6ULL, which probably regress the > combination of older DTBs with newer kernel. > > > > Agreed. Why can't we just tack on more numbers at the end? Ah, yes, I saw 6ULL are at the end of 6UL, so added them in 6UL, but did NOT consider the old dtb support. Will send out a V2 patch to fix it, and I saw Fabio also sent a patch to fix the clko1/2 definition, I will do the V2 patch based on his patch. Anson. > > > > > > > /* For i.MX6ULL */ > > > -#define IMX6ULL_CLK_ESAI_PRED 232 ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
