On Thu, May 31, 2018 at 10:58:59AM -0500, Rob Herring wrote: > On Thu, May 31, 2018 at 9:34 AM, Johan Hovold <johan@xxxxxxxxxx> wrote: > > On Thu, May 31, 2018 at 08:55:10AM -0500, Rob Herring wrote: > >> On Thu, May 31, 2018 at 3:22 AM, Johan Hovold <johan@xxxxxxxxxx> wrote: > >> > On Wed, May 30, 2018 at 10:58:05PM -0500, Rob Herring wrote: > >> >> On Wed, May 30, 2018 at 12:32:38PM +0200, Johan Hovold wrote: > >> >> > Add binding for u-blox GNSS receivers. > >> >> > +Optional properties: > >> >> > + > >> >> > +- timepulse-gpios : Time pulse GPIO > >> >> > +- u-blox,extint-gpios : External interrupt GPIO > >> >> > >> >> This should be interrupts property instead of a gpio. > >> > > >> > Contrary to what the name may suggest, this pin is actually an input > >> > which can be used to control active power or to provide time or > >> > frequency aiding data to the receiver (see section 1.13 in [1]). > >> > > >> > I only added it for completeness as the driver does not use it > >> > currently. Remove, leave as is, or add "input" to the description as in: > >> > > >> > - u-blox,extint-gpios : External interrupt input GPIO > >> > >> Yes. You should also define the active level. > > > > The active level appears to be runtime configurable and dependent on the > > selected function. For power control it can be used to control force-on > > (active high), force-off (active low) or both; and for time aiding > > sampling on falling or rising edge is also configurable. And who knows > > what else this pin is used for next time they update the firmware. ;) > > Okay. > > > Shall I remove the property, or just add "input" as suggested above? > > Just add "input". I ended up rewording this as u-blox,extint-gpios : GPIO connected to the "external interrupt" input pin to avoid any confusion about the direction of the GPIO. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
