Hi Simon, On Tue, May 29, 2018 at 3:05 PM, Simon Horman <horms@xxxxxxxxxxxx> wrote: > On Mon, May 28, 2018 at 11:13:08PM +0300, Sergei Shtylyov wrote: >> Define the generic R8A77980 parts of the I2C[0-5] device node. >> >> Based on the original (and large) patch by Vladimir Barinov. >> >> Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> >> + i2c3: i2c@e66d0000 { >> + compatible = "renesas,i2c-r8a77980", >> + "renesas,rcar-gen3-i2c"; >> + reg = <0 0xe66d0000 0 0x40>; >> + interrupts = <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&cpg CPG_MOD 928>; >> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; >> + resets = <&cpg 928>; >> + dmas = <&dmac1 0x97>, <&dmac1 0x96>, >> + <&dmac2 0x97>, <&dmac2 0x96>; >> + dma-names = "tx", "rx", "tx", "rx"; >> + i2c-scl-internal-delay-ns = <6>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + status = "disabled"; >> + }; > > DMA for i2c3 and i2c4 seems unclear in v0.80 and v1.00 of the User's Manual. > Although what is described here does match v0.55E of the User's Manual. > Have you been able to confirm what is correct here? Given they bothered adding rows to the table, I assume they just forgot to add checkmarks in the V3H column. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html