On 25-05-18, 14:10, Olof Johansson wrote: > On Fri, May 25, 2018 at 11:10:01AM +0530, Viresh Kumar wrote: > > The cooling device properties, like "#cooling-cells" and > > "dynamic-power-coefficient", should either be present for all the CPUs > > of a cluster or none. If these are present only for a subset of CPUs of > > a cluster then things will start falling apart as soon as the CPUs are > > brought online in a different order. For example, this will happen > > because the operating system looks for such properties in the CPU node > > it is trying to bring up, so that it can register a cooling device. > > > > Add such missing properties. > > This seems awkward compared to just having one cooling-cells in the /cpus node > instead. Well, we don't allow that property to be present in /cpus node right now and it is per device. And then we may not want all the CPUs to be cooling devices really. > What's it used for? I don't see any properties in the device nodes on meson-gxm > that have any cooling-foo cells in them? So why should #cooling-cells be > needed? This property is required to declare a device as a cooling-device and the device here is CPU. We use it as a cooling device by limiting its higher range of frequencies, so that it doesn't generate too much heat. It is already there for CPU0 and CPU4, but it should really be there for all the CPUs, like we have clock, supply, caches, etc. -- viresh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
