On Thu, May 24, 2018 at 1:12 AM, Marek Vasut <marex@xxxxxxx> wrote: > On 05/18/2018 11:28 AM, Qiang Yu wrote: >> GP is a processor for OpenGL vertex shader >> processing. >> >> Signed-off-by: Qiang Yu <yuq825@xxxxxxxxx> > > [...] > >> +int lima_gp_init(struct lima_ip *ip) >> +{ >> + struct lima_device *dev = ip->dev; >> + int err; >> + >> + lima_gp_print_version(ip); >> + >> + ip->data.async_reset = false; >> + lima_gp_soft_reset_async(ip); >> + err = lima_gp_soft_reset_async_wait(ip); >> + if (err) >> + return err; >> + >> + err = devm_request_irq(dev->dev, ip->irq, lima_gp_irq_handler, 0, >> + lima_ip_name(ip), ip); > > IRQF_SHARED, since there are designs (like zynqmp) where there is only > one IRQ line for the entire GPU. Right, will add this flag. Regards, Qiang > >> + if (err) { >> + dev_err(dev->dev, "gp %s fail to request irq\n", >> + lima_ip_name(ip)); >> + return err; >> + } >> + >> + return 0; >> +} > > > [...] > > -- > Best regards, > Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html