Hi Linus, On 23 May 2018 09:29, Linus Walleij wrote: > On Fri, May 11, 2018 at 10:31 AM, Phil Edworthy wrote: > > > The DesignWare GPIO IP can be configured for either 1 interrupt or 1 > > per GPIO in port A, but the driver currently only supports 1 interrupt. > > See the DesignWare DW_apb_gpio Databook description of the > > 'GPIO_INTR_IO' parameter. > > > > This change allows the driver to work with up to 32 interrupts, it > > will get as many interrupts as specified in the DT 'interrupts' property. > > It doesn't do anything clever with the different interrupts, it just > > calls the same handler used for single interrupt hardware. > > > > Signed-off-by: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> > > --- > > One point to mention is that I have made it possible for users to have > > unconnected interrupts by specifying holes in the list of interrupts. > > This is done by supporting the interrupts-extended DT prop. > > However, I have no use for this and had to hack some test case for this. > > Perhaps the driver should support 1 interrupt or all GPIOa as interrupts? > > > > v6: > > - Treat DT and ACPI the same as much as possible. Note that we can't use > > platform_get_irq() to get the DT interrupts as they are in the port > > sub-node and hence do not have an associated platform device. > > I already applied this patch in some version, can you check what is in my > devel branch and send incremental patches on top if something needs > changing? > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux- > gpio.git/commit/?h=devel&id=e6ca26abd37606ba4864f20c85d3fe4a2173b93f > > Sorry for not knowing by heart what was applied or when, it's just too much > for me sometimes. No problem, I'll send a patch with the incremental changes. Thanks Phil ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
