Thanks Rob for the review and the feedback! In the next patches, I split the bindings to a separate patch. On Die, 2018-05-22 at 12:19 -0500, Rob Herring wrote: > On Sun, May 20, 2018 at 02:19:17AM +0200, Silvan Murer wrote: > > > > Add support for external reference voltage through the regulator > > framework. > > > > Signed-off-by: Silvan Murer <silvan.murer@xxxxxxxxx> > > Reviewed-by: Lars-Peter Clausen <lars@xxxxxxxxxx> > > --- > > Changes in v3: > > - remove extra spaces and tab > > Changes in v2: > > - Add 'optional properties' documentation > > - Return an error when a regulator is specified > > - Use internal reference when no regulator is specified > > - Use iio_device_register instead of devm_iio_device_register > > > > .../devicetree/bindings/iio/dac/ltc2632.txt | 14 +++++ > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > In the future, please split bindings to separate patch. > > > > > drivers/iio/dac/ltc2632.c | 70 > > +++++++++++++++++++--- > > 2 files changed, 75 insertions(+), 9 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
