On Thu, May 10, 2018 at 08:47:48PM +0200, Paul Cercueil wrote: > Also remove the watchdog platform_device from platform.c, since it > wasn't used anywhere anyway. Nit: it'd be slightly nicer IMO if the patch body was a superset of the subject line. It's fine to repeat what the subject says since thats meant to summarise the body. > -struct platform_device jz4740_wdt_device = { There's an extern in arch/mips/include/asm/mach-jz4740/platform.h that should perhaps be removed also? Otherwise Acked-by: James Hogan <jhogan@xxxxxxxxxx> I'm happy to apply for 4.18 with that change if you want it to go through the MIPS tree. Cheers James
Attachment:
signature.asc
Description: PGP signature