On Tue, Feb 18, 2014 at 02:58:14PM +0000, Arnd Bergmann wrote: > On Tuesday 18 February 2014, Mark Rutland wrote: > > > > > > - These are Spear SoC specific miscellaneous registers. Here these are used for > > > to configure sata/pcie aux clock. > > > > > > > > > +- phy-id: Instance id of the phy. > > > > > +- #phy-cells : from the generic PHY bindings, must be 1. > > > > > + - 1st cell: phandle to the phy node. > > > > > + - 2nd cell: 0 if phy (in 1st cell) is to be used for SATA, 1 for PCIe > > > > > + and 2 for Super Speed USB. > > > > > > > > One cell or two? > > > > > > - No of cells are two, is this the question? > > > > The description of #phy-cells says it must be 1. Presumably it must be 2. > > The description here is counting the phandle, while we normally only > count the arguments following the phandle. #phy-cells=<1> is correct > here, but the description should be written a bit clearer. Ah, yes. I clearly hadn't read thoroughly enough. We could just drop mention of the phandle under the #phy-cells description; it's not relevant to the meaning of the single phy-specific cell, and per the phy binding it's obviously required in clients. Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
