On Thu, May 03, 2018 at 11:35:21AM +0200, H. Nikolaus Schaller wrote: > I have realized that the w2sg0004 is an exception (although a Sirf chip) > that it does not provide a WAKEUP signal. And another significant > difference is that we have to keep the serdev UART enabled even if there > is no user-space client. Otherwise we are not able to detect unexpected > activity. So we unfortunately can't move serdev open/close into the .open > and .close ops but need to open it in probe. As have also been discussed elsewhere in this thread it may be possible, and it is definitely desirable, to only keep the port open when really needed. But given the complexity of implementing this, starting with a simpler and less power efficient method for sirf-chips without WAKEUP may be acceptable. > Therefore, it is in my opinion still better to have a separate driver for > the w2sg0004 instead of hacking the support of this chip into your WAKEUP > capable sirfstar driver. So I suggest that you make WAKEUP a required > property. I disagree. The sirf driver subsumes your particular wi2wi module and configurations without WAKEUP are described by the datasheets for other modules as well. > We had faced a comparable decision last year with the ov9650 and ov9655 camera > sensors which are almost the same. But not same enough to integrate both into > a single driver. But here we are talking about two configuration for the same chip (even if your particular chip only supports one). Johan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
