> -----Original Message----- > From: Rob Herring [mailto:robh@xxxxxxxxxx] > Sent: Tuesday, May 1, 2018 11:37 PM > To: A.s. Dong <aisheng.dong@xxxxxxx> > Cc: linux-clk@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > sboyd@xxxxxxxxxx; mturquette@xxxxxxxxxxxx; shawnguo@xxxxxxxxxx; Fabio > Estevam <fabio.estevam@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; > kernel@xxxxxxxxxxxxxx; Mark Rutland <mark.rutland@xxxxxxx>; > devicetree@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 11/12] dt-bindings: clock: add imx8qxp clock binding doc > > On Sat, Apr 28, 2018 at 02:56:42AM +0800, Dong Aisheng wrote: > > Add imx8qxp clock binding doc. > > > > Cc: Shawn Guo <shawnguo@xxxxxxxxxx> > > Cc: Sascha Hauer <kernel@xxxxxxxxxxxxxx> > > Cc: Fabio Estevam <fabio.estevam@xxxxxxx> > > Cc: Stephen Boyd <sboyd@xxxxxxxxxx> > > Cc: Michael Turquette <mturquette@xxxxxxxxxxxx> > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > Cc: Mark Rutland <mark.rutland@xxxxxxx> > > Cc: devicetree@xxxxxxxxxxxxxxx > > Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx> > > --- > > .../devicetree/bindings/clock/imx8qxp-clk.txt | 39 +++ > > include/dt-bindings/clock/imx8qxp-clock.h | 362 > +++++++++++++++++++++ > > 2 files changed, 401 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/clock/imx8qxp-clk.txt > > create mode 100644 include/dt-bindings/clock/imx8qxp-clock.h > > > > diff --git a/Documentation/devicetree/bindings/clock/imx8qxp-clk.txt > > b/Documentation/devicetree/bindings/clock/imx8qxp-clk.txt > > new file mode 100644 > > index 0000000..5e365d7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/imx8qxp-clk.txt > > @@ -0,0 +1,39 @@ > > +NXP i.MX8QXP Clocks Based on SCFW > > +-------------------------------------------------------------------- > > + > > +Some i.MX SoCs contain a system controller that is responsible for > > +providing clock control service for the IPs. Communication between > > +the host processor running an OS and the system controller happens > > +through a SCU protocol [1]. > > + > > +[1] Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > + > > +Required properties: > > + > > +- compatible: Should be "fsl,imx8qxp-clock". > > +- #clock-cells: Should be <1>. > > There's no reason for this node. Just make the parent (SCU) a clock provider. > It can be done, but do I need to also remove other nodes like pinctrl, power domain in the same sub-nodes Of SCU? BTW i saw arm,scpi.txt also keep the clk node under scpi node. Documentation/devicetree/bindings/arm/arm,scpi.txt Seems like SCU like ARM SCPI is more like a protocol node while still needs different drivers to provide services. Regards Dong Aisheng > > + > > +The clock consumer should specify the desired clock by having the > > +clock ID in its "clocks" phandle cell. > > +See include/dt-bindings/clock/imx8qxp-clock.h > > +for the full list of i.MX8QXP clock IDs. > > + > > +Examples: > > + > > +#include <dt-bindings/clock/imx8qxp-clock.h> > > + > > +clk: clk { > > + compatible = "fsl,imx8qxp-clk"; > > + #clock-cells = <1>; > > +}; > > + > > +i2c0: i2c@5a800000 { > > + compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c"; > > + reg = <0x0 0x5a800000 0x0 0x4000>; > > + interrupts = <GIC_SPI 220 IRQ_TYPE_LEVEL_HIGH>; > > + interrupt-parent = <&gic>; > > + clocks = <&clk IMX8QXP_I2C0_CLK>, > > + <&clk IMX8QXP_I2C0_IPG_CLK>; > > + clock-names = "per", "ipg"; > > + ... > > +}; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
