On Thu, Apr 26, 2018 at 3:57 AM, Anson Huang <anson.huang@xxxxxxx> wrote: > The 'phy-supply' is for enabling/disabling phy regulator, but here the MAX7322 IO0 is NOT for > enabling/disabling PHY regulator, it is for IO voltage switch between 1.5V and 1.8V, our ENET > IO can work with both 1.5V and 1.8V, so any config is OK for ENET function. Thanks for the clarification. > The 1.5V/1.8V selection is a one time setting thing, that means we only need to > config it once during boot up, most of i.MX platforms does NOT provide such voltage > switch function for ENET IO, on this 6SX sabre auto board, it is more like a backup or > validation purpose. With default settings, ENET's function is NOT impacted at all. > > I think we can add a gpio regulator for it and let the regulator initialization set the GPIO > Level for fec, such below, with " enable-active-high " present, GPIO will be at LOW and voltage > is 1.5V, without this property, GPIO will be HIGH and voltage will be 1.8V. > + reg_fec: fec_io_supply { > + compatible = "regulator-gpio"; > + regulator-name = "1.8V_1.5V_FEC"; > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <1800000>; > + states = <1500000 0x0 1800000 0x1>; > + enable-gpio = <&max7322 0 GPIO_ACTIVE_HIGH>; > + vin-supply = <&sw2_reg>; > + enable-active-high; If there is no consumer for this regulator, the regulator API will disable it. It seems you need a 'regulator-always-on;'. > + }; > + > > Anson. > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html