On Thu, Apr 26, 2018 at 3:31 AM, Anson Huang <anson.huang@xxxxxxx> wrote: > I searched the mail I sent, I can NOT found where I said "MAX7310 controls the ethernet phy".... Initially you passed: pinctrl-assert-gpios = <&max7322 0 GPIO_ACTIVE_HIGH> inside the fec1 node. Then I explained that 'pinctrl-assert-gpios' is not a valid property in mainline. It only exists in NXP vendor tree. Then you explained: "Sorry, I made a mistake here, the MAX7320 IO0 is for adjusting FEC1's voltage" > There are MAX7310 users, it is just because currently those users are NOT enabled, so I can > NOT verify them. MAX7310 is an independent I2C device, why we can NOT enable it first? > I tested it from sysfs interface, we can control the MAX7310's IO output via echo different value > to GPIO value, that means MAX7310 itself as an IO expander chip is working just fine, similar with PMIC, > it is a I2C device, can be enabled independently, then consumers can be added later when they are enabled. > Just my personal opinion, thanks. Right, but if FEC needs max7322 IO0 at level 1 then better describe it in dts. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
