On 04/24/2018 06:27 PM, Rob Herring wrote: > On Wed, Apr 18, 2018 at 05:37:52PM +0200, Fabrice Gasnier wrote: >> Document support for STM32MP1 ADC. It's quite similar to STM32H7 ADC. >> Introduce "st,stm32mp1-adc" compatible to handle variants of this >> hardware such as vregready flag, interrupts, clock rate. >> >> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@xxxxxx> >> --- >> Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt >> index e8bb824..9994384 100644 >> --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt >> +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt >> @@ -24,8 +24,11 @@ Required properties: >> - compatible: Should be one of: >> "st,stm32f4-adc-core" >> "st,stm32h7-adc-core" >> + "st,stm32mp1-adc-core" >> - reg: Offset and length of the ADC block register set. >> -- interrupts: Must contain the interrupt for ADC block. >> +- interrupts: One or more interrupts for ADC block. Some parts like stm32f4 >> + and stm32h7 share a common ADC interrupt line. stm32mp1 has separate >> + lines for each ADC within ADC block. > > How many interrupt lines is that? Hi Rob, Jonathan, I should have mentioned this: stm32mp1 has two separate interrupt lines for each ADC within ADC block. Do you wish I send a V2 for this ? Or a patch to fix this ? Please let me know, BR, Fabrice > >> - clocks: Core can use up to two clocks, depending on part used: >> - "adc" clock: for the analog circuitry, common to all ADCs. >> It's required on stm32f4. >> @@ -53,6 +56,7 @@ Required properties: >> - compatible: Should be one of: >> "st,stm32f4-adc" >> "st,stm32h7-adc" >> + "st,stm32mp1-adc" >> - reg: Offset of ADC instance in ADC block (e.g. may be 0x0, 0x100, 0x200). >> - clocks: Input clock private to this ADC instance. It's required only on >> stm32f4, that has per instance clock input for registers access. >> -- >> 1.9.1 >> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
