On 04/17/2018 01:06 PM, Doug Anderson wrote: > [...] >> +- qcom,regulator-initial-voltage > > nit: regulator framework tends to include "microvolt" in the name to > make it really obvious in the device tree what the units are. Can you > do that too? Sure, I'll change the name to be: qcom,regulator-initial-microvolt. >> +- qcom,drms-mode-threshold-currents > > Could use microamp in the name of the property too... Ok, I'll change the name to be: qcom,drms-mode-max-microamps. >> + qcom,allowed-drms-modes = >> + <RPMH_REGULATOR_MODE_LPM >> + RPMH_REGULATOR_MODE_HPM>; >> + qcom,drms-mode-threshold-currents = <10000 1000000>; > > optional nit: to make it match downstream drivers, does it make sense > to change this to: > > <9999 999999> > > ...so if a driver used to request exactly 10000 mA that it will end up > with the same mode (no idea if drivers actually do that). I'd prefer to leave the example with <10000 1000000> as it looks cleaner to me and the example numbers are arbitrary. It would also be good to use <10000 1000000> in actual board DT files. We can address consumers expecting legacy behavior for 10000 uA requests as needed. Take care, David -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
