Hi, On Fri, Apr 13, 2018 at 7:50 PM, David Collins <collinsd@xxxxxxxxxxxxxx> wrote: > Introduce bindings for RPMh regulator devices found on some > Qualcomm Technlogies, Inc. SoCs. These devices allow a given > processor within the SoC to make PMIC regulator requests which > are aggregated within the RPMh hardware block along with requests > from other processors in the SoC to determine the final PMIC > regulator hardware state. > > Signed-off-by: David Collins <collinsd@xxxxxxxxxxxxxx> > --- > .../bindings/regulator/qcom,rpmh-regulator.txt | 207 +++++++++++++++++++++ > .../dt-bindings/regulator/qcom,rpmh-regulator.h | 36 ++++ > 2 files changed, 243 insertions(+) I noticed that "qcom,rpmh-resource-type" is now gone. Not needed anymore? Oh, I see. Stephen said to add it when it's needed. OK, fine. > +=============================== > +Second Level Nodes - Regulators > +=============================== > + > +- qcom,regulator-initial-voltage nit: regulator framework tends to include "microvolt" in the name to make it really obvious in the device tree what the units are. Can you do that too? > +- qcom,drms-mode-threshold-currents Could use microamp in the name of the property too... > + qcom,allowed-drms-modes = > + <RPMH_REGULATOR_MODE_LPM > + RPMH_REGULATOR_MODE_HPM>; > + qcom,drms-mode-threshold-currents = <10000 1000000>; optional nit: to make it match downstream drivers, does it make sense to change this to: <9999 999999> ...so if a driver used to request exactly 10000 mA that it will end up with the same mode (no idea if drivers actually do that). -Doug -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
