On Wed, Apr 18, 2018 at 09:38:47AM +0000, Vicenţiu Galanopulo wrote: > > > > > Having dev-addr stored in devices_addrs, in get_phy_c45_ids(), when > > > probing the identifiers, dev-addr can be extracted from devices_addrs > > > and probed if devices_addrs[current_identifier] is not 0. > > > > I must clearly be missing something, but why are you introducing all these > > conditionals instead of updating the existing code to be able to operate against > > an arbitrary dev-addr value, and then just making sure the first thing you do is > > fetch that property from Device Tree? There is no way someone is going to be > > testing with your specific use case in the future (except yourselves) so unless you > > make supporting an arbitrary "dev-addr" value become part of how the code > > works, this is going to be breaking badly. > > > > Hi Florian, > > My intention was to have this patch as "plugin" and modify the existing kernel API little to none. Hi Vicenţiu In Linux, kernel APIs are not sacred. If you need to change them, do so. We want a clear, well integrated solution, with minimal duplication. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
