On Tue, Apr 17, 2018 at 12:41:30AM +0900, Masahiro Yamada wrote: > arch/mips/boot/dts/Makefile collects objects from sub-directories > into built-in.a only when CONFIG_BUILTIN_DTB is enabled. Reflect > it also to the sub-directory Makefiles. This suppresses unneeded > built-in.a creation in arch/mips/boot/dts/*/ directories. > > While I am here, I replaced $(patsubst %.dtb, %.dtb.o, $(dtb-y)) > with $(addsuffix .o, $(dtb-y)) to simplify the code a little bit. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> > --- > > arch/mips/boot/dts/brcm/Makefile | 2 +- > arch/mips/boot/dts/cavium-octeon/Makefile | 2 +- > arch/mips/boot/dts/ingenic/Makefile | 2 +- > arch/mips/boot/dts/lantiq/Makefile | 2 +- > arch/mips/boot/dts/mscc/Makefile | 2 +- > arch/mips/boot/dts/mti/Makefile | 2 +- > arch/mips/boot/dts/netlogic/Makefile | 2 +- > arch/mips/boot/dts/pic32/Makefile | 2 +- > arch/mips/boot/dts/ralink/Makefile | 2 +- > arch/mips/boot/dts/xilfpga/Makefile | 2 +- > 10 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/arch/mips/boot/dts/brcm/Makefile b/arch/mips/boot/dts/brcm/Makefile > index d8787c9..d85f446 100644 > --- a/arch/mips/boot/dts/brcm/Makefile > +++ b/arch/mips/boot/dts/brcm/Makefile > @@ -34,4 +34,4 @@ dtb-$(CONFIG_DT_NONE) += \ > bcm97425svmb.dtb \ > bcm97435svmb.dtb > > -obj-y += $(patsubst %.dtb, %.dtb.o, $(dtb-y)) > +obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .o, $(dtb-y)) I like this. I had also spotted the .o files being unnecessarily generated when building the dtbs target with bmips and CONFIG_DT_NONE=y. I'll apply for 4.18. Thanks James
Attachment:
signature.asc
Description: Digital signature
