Re: [PATCH v5 4/5] ARM: Kirkwood: Fix qnap vendor prefix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed, 2014-02-19 at 22:49 +1000, klightspeed@xxxxxxxxxxxxxxxx wrote:
> Correct the vendor prefix for qnap, which should be the stock ticker
> symbol qnapsz.

No. This is an ABI change which appears to be gratuitous.

Perhaps it's really necessary, and perhaps it's harmless because it
won't *really* break compatibility with existing firmware because these
boxes have *always* shipped with a DTB built into the kernel or
something.

In which case all I'm complaining about is the fact that you didn't
properly address that in the commit comment and *explain* why it was
OK...

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@xxxxxxxxx                              Intel Corporation

Attachment: smime.p7s
Description: S/MIME cryptographic signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux