On 2018-04-13 10:11, Lars-Peter Clausen wrote: > On 04/13/2018 12:31 AM, Peter Rosin wrote: >> On 2018-04-12 17:35, Andrew F. Davis wrote: >>> On 04/12/2018 09:29 AM, Peter Rosin wrote: >>>> But as I said in the cover letter, I didn't go with sense-gain since I >>>> thought I would end up with requests for non-integer gains. There is >>>> yet to be a comment on the non-integer gain problem, and before there >>>> is a path forward for that case, I'm reluctant. >>> >>> Why not similar to what you had before with the resistor: >>> >>> sense-gain-multiplier >>> sense-gain-divider >>> >>> if either are missing assume they are 1. >> >> Hmm, how about sense-gain for the normal integer case, and then divide >> by sense-attenuation if needed? I.e. exactly the same functionality as >> you describe, just different names. > > There is some precedence in the clock bindings for using -mult and -div as > the suffix for fractional scales. See fixed-factor-clock.txt. Ok, I'm going with sense-gain-mult and sense-gain-div, but I'm going to diverge a little bit from the clock binding and make them optional with a default of 1 if missing. I'm also going to use the compatible "current-sense-amplifier", and not mention the LT6106, because I suspect that part can conceivable be used in other ways... But I'll wait for a bit with this and give everybody a last chance to pitch suggestions and opinions. Cheers, Peter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
