Hi again,
On Friday, 6 April 2018 16:45:16 EEST Laurent Pinchart wrote:
> On Friday, 6 April 2018 16:08:10 EEST Jacopo Mondi wrote:
> > Enable DU for Renesas R-Car V3M Eagle board.
> >
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> > ---
> >
> > arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> > b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts index 3c5f598..144b847
> > 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> > @@ -76,6 +76,11 @@
> >
> > function = "i2c0";
> >
> > };
> >
> > + du_pins: du {
> > + groups = "du_rgb666", "du_sync", "du_oddf", "du_clk_out";
> > + function = "du";
> > + };
>
> As far as I can tell the DU parallel output isn't used on the Eagle board,
> but is used on the Eagle expansion board. I would move this to patch 7/7 in
> this series.
My bad, patch 7/7 describes the on-board HDMI encoder, not the one on the
expansion board. I would thus drop pinmux completely for now until we add
support for the expansion board.
> > scif0_pins: scif0 {
> >
> > groups = "scif0_data";
> > function = "scif0";
> >
> > @@ -93,3 +98,9 @@
> >
> > status = "okay";
> >
> > };
> >
> > +
> > +&du {
> > + pinctrl-0 = <&du_pins>;
> > + pinctrl-names = "default";
>
> These two properties should be moved to patch 7/7 too.
So this should be removed.
> > + status = "okay";
> > +};
>
> There's little use for enabling the DU in DT if you have no output port
> described. I'd move this to patch 6/7.
And I'd merge the status attribute and patches 6/7 and 7/7 all together.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
