From: Moritz Fischer <mdf@xxxxxxxxxx>
Date: Fri, 23 Mar 2018 13:41:28 -0700
> +static void nixge_hw_dma_bd_release(struct net_device *ndev)
> +{
> + int i;
> + struct nixge_priv *priv = netdev_priv(ndev);
Please order local variables from longest to shortest line (ie. reverse
christmas tree layout).
> +static int nixge_hw_dma_bd_init(struct net_device *ndev)
> +{
> + u32 cr;
> + int i;
> + struct sk_buff *skb;
> + struct nixge_priv *priv = netdev_priv(ndev);
Likewise.
> +static void __nixge_device_reset(struct nixge_priv *priv, off_t offset)
> +{
> + u32 status;
> + int err;
> + /* Reset Axi DMA. This would reset NIXGE Ethernet core as well.
> + * The reset process of Axi DMA takes a while to complete as all
> + * pending commands/transfers will be flushed or completed during
> + * this reset process.
> + */
Please put an empty line between the local variable declarations
and this comment.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
