Hi,
On 21-03-18 12:19, Jun Li wrote:
-----Original Message-----
From: Hans de Goede [mailto:hdegoede@xxxxxxxxxx]
Sent: 2018年3月20日 20:29
To: Jun Li <jun.li@xxxxxxx>; gregkh@xxxxxxxxxxxxxxxxxxx;
robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx;
heikki.krogerus@xxxxxxxxxxxxxxx; linux@xxxxxxxxxxxx; rmfrfs@xxxxxxxxx;
yueyao.zhu@xxxxxxxxx
Cc: linux-usb@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; dl-linux-imx
<linux-imx@xxxxxxx>
Subject: Re: [PATCH 2/5] usb: typec: fusb302: remove max_snk_* for sink
config
Hi,
On 20-03-18 11:26, Li Jun wrote:
Since max_snk_* is to be deprecated, so remove max_snk_* by adding a
variable PDO for sink config.
NACK there are actual users of the device-properties which you are now
breaking. As I mentioned in another thread, you need to instead add the pdo
array to the fusb302_chip struct (so that it is no longer
const) and generate a PDO_VAR pdo based on the device-properties.
OK, I did a search of those properties in dts dir of upstream kernel
but didn't find any user of them,
Note that these properties are not accessed through the dt APIs but through the
generic device-properties API. And these are set as device-properties by the
driver instantiating the fusb302 i2c-client on (some) x86 boards:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/platform/x86/intel_cht_int33fe.c
> if there are actual of users, I will create
> a PDO_VAR pdo based on dt in v2.
Thank you.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
