On 03/19/2018 01:17 PM, Stephen Boyd wrote:
> Quoting Dinh Nguyen (2018-02-26 06:47:35)
>> diff --git a/drivers/clk/socfpga/Makefile b/drivers/clk/socfpga/Makefile
>> index 9146c20..87ef977 100644
>> --- a/drivers/clk/socfpga/Makefile
>> +++ b/drivers/clk/socfpga/Makefile
>> @@ -1,6 +1,11 @@
>> # SPDX-License-Identifier: GPL-2.0
>> +ifeq ($(CONFIG_ARCH_SOCFPGA),y)
>
> Ugh, any chance to make this better if we get three?
>
I'll try.
...
>
>> +{
>> + struct stratix10_clock_data *clk_data;
>> +
>> + clk_data = __socfpga_s10_clk_init(node, STRATIX10_NUM_CLKS);
>> + if (!clk_data)
>> + return;
>> +
>> + s10_clk_register_pll(s10_pll_clks, ARRAY_SIZE(s10_pll_clks), clk_data);
>> +
>> + s10_clk_register_c_perip(s10_main_perip_c_clks,
>> + ARRAY_SIZE(s10_main_perip_c_clks), clk_data);
>> +
>> + s10_clk_register_cnt_perip(s10_main_perip_cnt_clks,
>> + ARRAY_SIZE(s10_main_perip_cnt_clks),
>> + clk_data);
>> +
>> + s10_clk_register_gate(s10_gate_clks, ARRAY_SIZE(s10_gate_clks),
>> + clk_data);
>> +}
>> +
>> +CLK_OF_DECLARE(stratix10_clock, "intel,stratix10-clkmgr", socfpga_s10_init);
>
> Can it be a platform device? We prefer those over the CLK_OF_DECLARE
> style.
>
Thanks for the review! I'll change it to a platform device and address
your other comments in v7.
Dinh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
