Quoting Dinh Nguyen (2018-02-26 06:47:33) > diff --git a/Documentation/devicetree/bindings/clock/intc_stratix10.txt b/Documentation/devicetree/bindings/clock/intc_stratix10.txt > new file mode 100644 > index 0000000..0652ff1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/intc_stratix10.txt > @@ -0,0 +1,51 @@ > +Device Tree Clock bindings for Intel's SoCFPGA Stratix10 platform > + > +This binding uses the common clock binding[1]. > + > +[1] Documentation/devicetree/bindings/clock/clock-bindings.txt > + > +Required properties: > +- compatible : shall be > + "intel,stratix10-clkmgr" > + > +- reg : shall be the control register offset from CLOCK_MANAGER's base for the clock. > + > +- #clock-cells : from common clock binding, shall be set to 1. > + > +- clocks : Should contain fixed-clock sources, such as oscillators. > + > +Example: > + clkmgr: clock-controller@ffd10000 { > + compatible = "intel,stratix10-clkmgr"; > + reg = <0xffd10000 0x1000>; > + #clock-cells = <1>; > + > + clocks { Why do we need a subnode for clocks inside of a clock controller node? > + #address-cells = <1>; > + #size-cells = <0>; > + > + cb_intosc_hs_div2_clk: cb-intosc-hs-div2-clk { > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <25000000>; What is this for? I would think oscillators go into the root of the DT because they're on the board, not inside the clock controller. > + }; > + > + cb_intosc_ls_clk: cb-intosc-ls-clk { > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <25000000>; > + }; > + > + f2s_free_clk: f2s-free-clk { > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <25000000>; > + }; > + > + osc1: osc1 { > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <25000000>; > + }; > + }; > + }; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html