> -----Original Message----- > From: Stephen Boyd <sboyd@xxxxxxxxxx> > Sent: Monday, March 19, 2018 19:45 > To: Ilia Lin <ilialin@xxxxxxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-arm-msm@xxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; > sboyd@xxxxxxxxxxxxxx > Cc: mark.rutland@xxxxxxx; devicetree@xxxxxxxxxxxxxxx; > rnayak@xxxxxxxxxxxxxx; robh@xxxxxxxxxx; will.deacon@xxxxxxx; > amit.kucheria@xxxxxxxxxx; tfinkel@xxxxxxxxxxxxxx; ilialin@xxxxxxxxxxxxxx; > nicolas.dechesne@xxxxxxxxxx; celster@xxxxxxxxxxxxxx > Subject: Re: [PATCH v3 01/10] soc: qcom: Separate kryo l2 accessors from > PMU driver > > Quoting Ilia Lin (2018-02-14 05:59:43) > > diff --git a/arch/arm64/Kconfig.platforms > > b/arch/arm64/Kconfig.platforms index fbedbd8..78a103b 100644 > > --- a/arch/arm64/Kconfig.platforms > > +++ b/arch/arm64/Kconfig.platforms > > @@ -145,6 +145,13 @@ config ARCH_REALTEK > > This enables support for the ARMv8 based Realtek chipsets, > > like the RTD1295. > > > > +config ARCH_MSM8996 > > + bool "Enable Support for Qualcomm Technologies, Inc. MSM8996" > > + depends on ARCH_QCOM > > Is this really the proposed approach? Doesn't the PMU code use these > accessors? I would think the accessors are compiled if ARCH_QCOM=y so > that the PMU stuff keeps working. Drop this Kconfig addition? I'll check whether the kryo-accessors code is SOC specific or not. > > > + help > > + This enables support for the MSM8996 chipset. If you do not > > + wish to build a kernel that runs on this chipset, say 'N' here. > > + > > config ARCH_ROCKCHIP > > bool "Rockchip Platforms" > > select ARCH_HAS_RESET_CONTROLLER diff --git > > a/drivers/perf/qcom_l2_pmu.c b/drivers/perf/qcom_l2_pmu.c index > > 4fdc848..8cece9e 100644 > > --- a/drivers/perf/qcom_l2_pmu.c > > +++ b/drivers/perf/qcom_l2_pmu.c > > @@ -1,4 +1,4 @@ > > -/* Copyright (c) 2015-2017 The Linux Foundation. All rights reserved. > > +/* Copyright (c) 2015-2018 The Linux Foundation. All rights reserved. > > Sorry, this makes little sense. First off, code is only being deleted and more > than half the file isn't being modified so why update copyright dates? Agree. Will roll back. > > > * > > * This program is free software; you can redistribute it and/or modify > > * it under the terms of the GNU General Public License version 2 and > > diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile > > index dcebf28..4e91e2a 100644 > > --- a/drivers/soc/qcom/Makefile > > +++ b/drivers/soc/qcom/Makefile > > @@ -12,3 +12,4 @@ obj-$(CONFIG_QCOM_SMEM_STATE) += > smem_state.o > > obj-$(CONFIG_QCOM_SMP2P) += smp2p.o > > obj-$(CONFIG_QCOM_SMSM) += smsm.o > > obj-$(CONFIG_QCOM_WCNSS_CTRL) += wcnss_ctrl.o > > +obj-$(CONFIG_ARCH_MSM8996) += kryo-l2-accessors.o > > diff --git a/drivers/soc/qcom/kryo-l2-accessors.c > > b/drivers/soc/qcom/kryo-l2-accessors.c > > new file mode 100644 > > index 0000000..6743848 > > --- /dev/null > > +++ b/drivers/soc/qcom/kryo-l2-accessors.c > > @@ -0,0 +1,64 @@ > > +/* > > + * Copyright (c) 2014-2015, 2018, The Linux Foundation. All rights reserved. > > + * > > + * This program is free software; you can redistribute it and/or > > +modify > > + * it under the terms of the GNU General Public License version 2 and > > + * only version 2 as published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > SPDX tags? Will do. > > > diff --git a/include/soc/qcom/kryo-l2-accessors.h > > b/include/soc/qcom/kryo-l2-accessors.h > > new file mode 100644 > > index 0000000..e9a5eab > > --- /dev/null > > +++ b/include/soc/qcom/kryo-l2-accessors.h > > @@ -0,0 +1,22 @@ > > +/* > > + * Copyright (c) 2018, The Linux Foundation. All rights reserved. > > + * > > + * This program is free software; you can redistribute it and/or > > +modify > > + * it under the terms of the GNU General Public License version 2 and > > + * only version 2 as published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +#ifndef __ASM_ARCH_MSM_MSM_KRYO_L2_ACCESSORS_H > > +#define __ASM_ARCH_MSM_MSM_KRYO_L2_ACCESSORS_H > > Maybe change this tO __SOC_ARCH_QCOM_KRYO_L2_ACCESSORS_H No problem. Will change. > > > + > > +#ifdef CONFIG_ARCH_QCOM > > +void set_l2_indirect_reg(u64 reg_addr, u64 val); > > +u64 get_l2_indirect_reg(u64 reg_addr); #endif > > This ifdef isn't doing much. Drop it? Or provide the inline nop alternatives. Right. I'll drop it. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
