Hi Rob and DT folks, On Mon, Feb 10, 2014 at 07:50:08PM +0800, Shawn Guo wrote: > Update fsl-fec to explicitly list the supported compatible strings > and add missing 'clocks' and 'clock-names' properties. It does not > change anything about how kernel drive works. Instead, it just reflects > how kernel driver works today. > > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx> Any comments? Or can it be applied? Shawn > --- > Documentation/devicetree/bindings/net/fsl-fec.txt | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt > index 845ff84..3ebd395 100644 > --- a/Documentation/devicetree/bindings/net/fsl-fec.txt > +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt > @@ -1,9 +1,26 @@ > * Freescale Fast Ethernet Controller (FEC) > > Required properties: > -- compatible : Should be "fsl,<soc>-fec" > +- compatible : Should contain one of the following: > + "fsl,imx25-fec" > + "fsl,imx27-fec" > + "fsl,imx28-fec" > + "fsl,imx6q-fec" > + "fsl,mvf600-fec" > - reg : Address and length of the register set for the device > - interrupts : Should contain fec interrupt > +- clocks: phandle to the clocks feeding the FEC controller and phy. The > + following two are required: > + - "ipg": the peripheral access clock > + - "ahb": the bus clock for MAC > + The following two are optional: > + - "ptp": the sampling clock for PTP (IEEE 1588). On SoC like i.MX6Q, > + the clock could come from either the internal clock control module > + or external oscillator via pad depending on board design. > + - "enet_out": the phy reference clock provided by SoC via pad, which > + is available on SoC like i.MX28. > +- clock-names: Must contain the clock names described just above > + > - phy-mode : String, operation mode of the PHY interface. > Supported values are: "mii", "gmii", "sgmii", "tbi", "rmii", > "rgmii", "rgmii-id", "rgmii-rxid", "rgmii-txid", "rtbi", "smii". > -- > 1.7.9.5 > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html