Hi Geert-san,
Thanks for your review.
2018-03-12 19:56 GMT+09:00 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
> Hi Kaneko-san,
>
> On Sun, Mar 11, 2018 at 9:26 PM, Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> wrote:
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx>
>
> Thanks for your patch!
>
>> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
>> @@ -402,5 +402,36 @@
>> #phy-cells = <0>;
>> status = "disabled";
>> };
>> +
>> + thermal: thermal@e61f0000 {
>
> According to the Hard User Manual rev. 0.80, the base address is e6190000?
You are correct.
I will update this patch to fix it.
>
>> + compatible = "renesas,thermal-r8a77995",
>> + "renesas,rcar-thermal";
>
> I would drop the fallback property, cfr. my comments on the DT binding
> patch.
Yes. I will do it.
>
>> + reg = <0 0xe61f0000 0 0x10>, <0 0xe61f0100 0 0x38>;
>
> 0xe619... (twice)
I will fix it.
Thanks,
Kaneko
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
