Hi Jacob, On Thu, Mar 08, 2018 at 05:47:59PM +0800, Jacob Chen wrote: > +config VIDEO_ROCKCHIP_ISP1 > + tristate "Rockchip Image Signal Processing v1 Unit driver" > + depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API > + depends on ARCH_ROCKCHIP || COMPILE_TEST > + select VIDEOBUF2_DMA_CONTIG > + select V4L2_FWNODE > + default n > + ---help--- > + Support for ISP1 on the rockchip SoC. I added 'select VIDEOBUF2_VMALLOC' here to fix link failure: drivers/media/platform/rockchip/isp1/isp_stats.o: In function `rkisp1_register_stats_vdev': isp_stats.c:(.text+0x80c): undefined reference to `vb2_vmalloc_memops' isp_stats.c:(.text+0x814): undefined reference to `vb2_vmalloc_memops' drivers/media/platform/rockchip/isp1/isp_params.o: In function `rkisp1_register_params_vdev': isp_params.c:(.text+0x29b4): undefined reference to `vb2_vmalloc_memops' isp_params.c:(.text+0x29bc): undefined reference to `vb2_vmalloc_memops' baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@xxxxxxxxxx - tel: +972.2.679.5364, http://www.tkos.co.il - -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html