Hi! > > + led@1 { > > + reg = <1>; > > + linux,default-trigger = "heartbeat"; > > + label = "an30259a:red:notification"; > > s/an30259a:red:notification/red:notification/ > > Let's drop devicename section from label, and make it a LED class > driver responsibility to prepend the label with devicename when > composing LED class device name. Is it good idea? (Some existing bindings specify three-part label in the label, some do not. Documentation/devicetree/bindings/leds/leds-netxbig.txt vs. Documentation/devicetree/bindings/leds/leds-mt6323.txt :-( We should really solve that somehow). I'd really like to see input0:white:numlock in the name, so same software has a chance to work on PC and ARM notebook. Prepending an30259a in the driver will break that... Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature