On Thu, 08 Mar 2018, Sebastian Reichel wrote: > On Thu, Mar 08, 2018 at 09:53:15AM +0000, Lee Jones wrote: > > On Thu, 08 Mar 2018, Sebastian Reichel wrote: > > > On Wed, Mar 07, 2018 at 04:32:11PM +0000, Lee Jones wrote: > > > > On Fri, 23 Feb 2018, Sebastian Reichel wrote: > > > > > +static const struct mfd_cell cpcap_mfd_devices[] = { > > > > > > [...] > > > > > > > > + }, { > > > > > + .name = "cpcap-led", > > > > > + .id = 4, > > > > > + .of_compatible = "motorola,cpcap-led-cp", > > > > > + }, { > > > > > + .name = "cpcap-codec", > > > > > + } > > > > > +}; > > > > > > > > With none of the entries containing platform_data /me wonders why you > > > > can't still use devm_of_platform_populate()? > > > > > > Because devm_of_platform_populate works with compatible properties and > > > cpcap-codec does not have one after I removed it for Mark. > > > > Sorry, I missed that conversation. Why was it removed? > > I had it in PATCHv1-PATCHv4. It was removed, since Mark didn't want > to have it in the DT ABI. Right, but why? Is it not a hardware device? I think converting from devm_of_platform_populate() for one sub-device is a bit drastic. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html