Hi Lee, On Wed, Mar 07, 2018 at 04:32:11PM +0000, Lee Jones wrote: > On Fri, 23 Feb 2018, Sebastian Reichel wrote: > > +static const struct mfd_cell cpcap_mfd_devices[] = { [...] > > + }, { > > + .name = "cpcap-led", > > + .id = 4, > > + .of_compatible = "motorola,cpcap-led-cp", > > + }, { > > + .name = "cpcap-codec", > > + } > > +}; > > With none of the entries containing platform_data /me wonders why you > can't still use devm_of_platform_populate()? Because devm_of_platform_populate works with compatible properties and cpcap-codec does not have one after I removed it for Mark. -- Sebastian > > static int cpcap_probe(struct spi_device *spi) > > { > > const struct of_device_id *match; > > @@ -260,7 +308,8 @@ static int cpcap_probe(struct spi_device *spi) > > if (ret) > > return ret; > > > > - return devm_of_platform_populate(&cpcap->spi->dev); > > + return devm_mfd_add_devices(&spi->dev, 0, cpcap_mfd_devices, > > + ARRAY_SIZE(cpcap_mfd_devices), NULL, 0, NULL); > > } > > > > static struct spi_driver cpcap_driver = { > > -- > Lee Jones > Linaro Services Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog
Attachment:
signature.asc
Description: PGP signature